Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save MIDI Channel assignments to tuning slots #116

Open
wants to merge 3 commits into
base: testing
Choose a base branch
from

Conversation

KohlJary
Copy link

Issue #114

Implemented changing the midi channel for each string and saving that information down in the user tuning slots. Could also be an instrument level setting, would just have to move the menu up out of the tuning section, but figured being able to save the channel layout to a preset slot would mean you could have multiple sample sets/synth multipatches set up and be able to switch between them relatively on the fly.

@KohlJary KohlJary changed the base branch from main to testing September 14, 2023 06:35
@KohlJary KohlJary force-pushed the feature/kj/change-midi-channel branch from 039b46f to fa66612 Compare September 14, 2023 06:40
@bazmonk
Copy link
Owner

bazmonk commented Sep 14, 2023 via email

@KohlJary
Copy link
Author

Let me know if there are further tweaks to make, was thinking it might make sense to load whatever the config values for the midi channels are set to when loading the preset tunings for instance. If the amount of space taken up in the EEPROM for having the channel assignments saved per preset is too much, could instead use a system wide setting only. I just know I could see utility in being able to assign channels per preset for my own setup.

@KohlJary
Copy link
Author

And if there's anything else you could use help with in maintaining/improving this project, please don't hesitate to reach out. Been meaning to enhance my C++ knowledge anyways and this is a neat project to do that with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants